Thread: Javascript Help Please!

I have a snippet of code:

PHP Code:

switch (id)
{
    case 1:
        doFunction(parameter1);
        break;
    case 2:
        doFunction(parameter2);
        break;
    case 3:
        doFunction(parameter3);
        break;
    default:
        document.write('Error: '+id);
} 


The strange thing is that the document says, "Error: 3". If the variable id is equal to 3, then why didn't the switch statement go through case 3? I must have something confused.

Help anyone?

hmm... what kind of data type is your ID variable? There doesn't seem to be any specific errors within the snippet you provided. Since it doesn't find any match within the switch statement my only guess would be that the data type you try to match with the cases are different.

I'd agree with SomeDreamer. Show more of the JS

Maybe the 3 you give it is a string or a character. Try to add

Code:

id = parseInt(id);

before the switch statement.

Originally Posted by khh

Maybe the 3 you give it is a string or a character. Try to add

Code:

id = parseInt(id);

before the switch statement.

Thanks a lot! That did the trick

Thanks a lot! That did the trick

Basically the same thing as mentioned by me then. Don't know if it should have been explained better, but the idea is that the switch variable you use need to match the same data type as the case values. So in this example you used a string and tried to compare it to an integer type (case 1, etc).

It's also allowed to change the switch statement to the likes of the data type you're comparing it with, like:

switch (id)
{
case "1":
doFunction(parameter1);
break;
case "2":
doFunction(parameter2);
break;
case "3":
doFunction(parameter3);
break;
default:
document.write('Error: '+id);
}

When embedded in quotes, it's now taken as a string, and your code would also have worked. Obviously this solution isn't as pretty converting the switch variable before comparing But gives you the general idea.